magento-hackathon / magento-composer-installer

Composer installer for Magento modules
210 stars 154 forks source link

Uninstall Magento Module doesnt delete /etc/modules/Vendor_Package.xml file. #84

Closed jaypatel512 closed 10 years ago

jaypatel512 commented 10 years ago

Hey there,

When I tried using composer to uninstall an extension with copy strategy, it is somehow not deleting /etc/modules/Vendor_Package.xml file. Is this a bug, or are we not removing it for some reason.

This is how my json looks like.

 {                                                                                                                                                                                
          "require":{
                          "connect20/mage_all_latest":"*"
                  },
                  "repositories":[{
                          "type":"composer",
                          "url":"http://packages.firegento.com"
                  },{
                          "type":"git",
                          "url":"git://github.com/jaypatel512/composer.git"
                  }
          ],
                  "extra":{
                          "magento-root-dir":"./htdocs/",
                         "magento-deploystrategy":"copy",
                         "magento-force":"override"
                 }
  }
Flyingmana commented 10 years ago

Which version of the installer do you have?

jaypatel512 commented 10 years ago

From composer.lock 1.3.2

Flyingmana commented 10 years ago

could you try 2.0.0-beta1 or dev-master and see if the problem persists?

jaypatel512 commented 10 years ago

It works with beta ! :) Thanks.

jaypatel512 commented 10 years ago

Also, I have a question related to using connect20/Mage_All_Latest. My Question is, as you have Mage_Core_Modules include the skeleton of entire Magento 1.x, what happens when I update that module ? Will it remove all the extensions from app/code folder ? Or will it cherry pick only folders that are part of Mage_Core_Modules only.

Flyingmana commented 10 years ago

Iam sorry, but we currently have no tests which cover this behavior, so I would say its not predictable.

Flyingmana commented 10 years ago

it should cherry pick all files, as core modules use the package.xml which references every file separate.