search

magento-hackathon / magento-composer-installer

Composer installer for Magento modules
210 stars 154 forks source link

Deploy-strategy copy failed after the very first install #85

Closed yellowmamba closed 10 years ago

yellowmamba commented 10 years ago

Hi folks,

I have found a problem that if you already have your extension in vendor directory, it won't get copied again to Magento repo after you update the extension repo and do composer update. Also, when you have multiple plugins from the same vendor, composer update/install will cause some files missing for some reason. For example, we have a couple of plugins from AheadWorks, blog, RMA, etc. On first install, everything is fine, but if you run composer install/update again, some files will be missing in the Magento repo, such as files in app/code/community/AW/Blog/etc/

As an interim solution, I have to delete web/.gitignore file and clean up all copied files using git clean -f -d and redo a composer install

Cheers.

Flyingmana commented 10 years ago

Which version of the installer do you have?

yellowmamba commented 10 years ago

Master branch

Flyingmana commented 10 years ago

not reproducable for me. are there any errors in your unittests?

yellowmamba commented 10 years ago

No errors in unit tests. Anyway, it's not affecting our deployment. Please ignore this for now.

BTW, the current master is failing, can you advise the stable release? I seem to remember it was 1.3.1, but it'd be great to get your confirmation. Thanks!

Flyingmana commented 10 years ago

the current master is failing because of new added tests, which are probably would fail for all older versions. But the problem should not affect much packages

yellowmamba commented 10 years ago

Cool, I will use 1.3.1 then, as that's all we need for our project. Thanks. I am closing it now as the issue I raised is not reproducible and can be addressed on our own. Will reopen this if needed in the future.