magento-hackathon / magento-composer-installer

Composer installer for Magento modules
210 stars 154 forks source link

auto-append-gitignore not working #96

Open tkdb opened 10 years ago

tkdb commented 10 years ago

I'm aware of #81 - it just does not make it. This is a simple failure report.

My composer.json:

{
    "require": {
        "connect20/dsdata_nostate":"*"
    },
    "repositories": [
        {
            "type": "composer",
            "url": "http://packages.firegento.com"
        }
    ],
    "extra": {
        "magento-root-dir": "magento/",
        "auto-append-gitignore": true
    }
}

The .gitingore file when operating in the same directory remains untouched. Files are linked in the FS.

tkdb commented 10 years ago

This comment is all wrong, symlinks work fine both on linux and windows. I just didn't see them properly in my file manager.

I have to correct - even I saw errors in Windows regarding symlink() and fixed those errors (triggered in that symlink strategy file line 103) , it's just that ~~both on windows ~~and linux systems that connect20/dsdata_nostate module (Dsdata_NoState) is not installed by linking but by copying files.

tkdb commented 10 years ago

Could it be that this won't work if there ain't a .gitignore in the magento-root-dir allready?

I have a gitignore at the projects root folder (which is where composer.json resides) while the magento-root-dir is "magento/" and there is no .gitignore file.

tkdb commented 10 years ago

Just a quick update, for the first install I did with 2.x (I did use 1.3.x before), this seemed to work. .gitignore was updated yesterday. Ref: https://github.com/magento-hackathon/magento-composer-installer/issues/107#issuecomment-46412177

A new .gitignore file was created in the magento root directory in my case:

    "extra": {
        "magento-root-dir": "magento/",
        "auto-append-gitignore": true
    }
}