search

magento-hackathon / magento2-toolbar

Toolbar with developer and merchant functionality
Open Software License 3.0
28 stars 7 forks source link

Fixed version constraint for debugbar #3

Closed elzekool closed 8 years ago

elzekool commented 8 years ago

Version constraint of debugbar has an issue, if following the simver version standard you should use ~1.12 or use ^1.12.0. This is because composer will see 1.12 as major version instead of 1 as it should. You van use https://semver.mwl.be/#?package=maximebf%2Fdebugbar&version=%5E1.12&minimum-stability=stable to test out version constraints

barryvdh commented 8 years ago

This was intentional for me. Although debugbar does try to follow SemVer, at least for it's public API/interfaces, but sometimes some changes are not 100% compatible, mostly in overriding some js/css settings etc. That's why I locked it to a minor version instead of major.

elzekool commented 8 years ago

Okay, I see, then I think we should use 1.12.* to better reflect this, I updated the PR

barryvdh commented 8 years ago

(Y)