search

magento-hackathon / magento2-toolbar

Toolbar with developer and merchant functionality
Open Software License 3.0
28 stars 7 forks source link

Made the toolbar a little bit more flat #7

Closed elzekool closed 8 years ago

elzekool commented 8 years ago

Made the toolbar a little more flat by removing some borders and adding some padding/margins, etc.

screenshot from 2016-05-17 21-06-52

barryvdh commented 8 years ago

Cool, tab headers do seem a bit thin now, but hey, I'm not a designer :P

barryvdh commented 8 years ago

Just pulled down in my branch, tabs look better then in the screenshot :) Bit high for my taste, but guess that's just matter of personal taste.

elzekool commented 8 years ago

I predicted you would find it a little big, I put my inspiration from the Zend Toolbar and the Symfony toolbar, both about 40px high. I think it's more in line with the average navigation height in Magento backend, and less "developer" style.

elzekool commented 8 years ago

@barryvdh Are you ok with merging it?

barryvdh commented 8 years ago

Yes

barryvdh commented 8 years ago

Merged :)

barryvdh commented 8 years ago

I think the height is pretty good when collapsed, just when opened, it seems a bit unnecessary large in contrast with the rest below.