magento-hackathon / magento2-toolbar

Toolbar with developer and merchant functionality
Open Software License 3.0
28 stars 7 forks source link

Change default collectors, aggregate messages #8

Closed barryvdh closed 8 years ago

barryvdh commented 8 years ago

So let's think about which collectors are added by default, and which need to be extracted to a separate package.

I understand you want to keep this repo as 'clean' as possible, but there is something to be said for some default collectors:

Separate developer collectors (to be extracted):

Possible extra developer collectors:

barryvdh commented 8 years ago

I extracted the collectors to my own extension; https://github.com/fruitcake/magento2-developer-toolbar

I added an AbstractCollector here, so de-duplicate code from the collectors.

@elzekool This good to merge?

barryvdh commented 8 years ago

Although perhaps we should add the 'default' datacollectors also by means of plugins, with a higher sortOrder. Eg. start the collectors with 100, 110, 120, so collectors can be added in front/between.

elzekool commented 8 years ago

@barryvdh Yeah perfect! I merged it