Add list components - Githubissues

magento-research / peregrine

(Defunct) Moved to https://github.com/magento-research/pwa-studio

Open Software License 3.0

29 stars 1 forks source link

Add list components #32

Closed jimbo closed 6 years ago

PWAStudioBot commented 6 years ago

All tests passed! View Coverage Report

A Storybook for this PR has been deployed!. It will be accessible as soon as the current build completes.

Generated by :no_entry_sign: dangerJS

jimbo commented 6 years ago

The size on this PR looks pretty large, but it's only three components. The tests, docs, and stories associated with these components contribute to the line change figure, plus the usual package-lock.json bloat.

DrewML commented 6 years ago

Think we should show the happy path here, where a string is passed in. This will look like a mistake to the average person looking through the storybook

zetlen commented 6 years ago

@jimbo If you have the chance while you're out, could you please go through the CLA process? (You should only ever need to do it once.) Also, could you merge from master and resolve conflicts?

DrewML commented 6 years ago

Added @storybook/addons per https://storybook.js.org/addons/using-addons/

jimbo commented 6 years ago

@zetlen I've signed the CLA. Should be clear now.