search

magento-research / peregrine

(Defunct) Moved to https://github.com/magento-research/pwa-studio
Open Software License 3.0
29 stars 1 forks source link

Ensure __tmp_webpack_public_path__ always has a trailing slash #36

Closed DrewML closed 6 years ago

DrewML commented 6 years ago

See: https://github.com/magento-research/venia-pwa-concept/pull/57

Reminder that __tmp_webpack_public_path__ goes away entirely once the backend work to support root components is done.

PWAStudioBot commented 6 years ago

All tests passed! View Coverage Report

A Storybook for this PR has been deployed!. It will be accessible as soon as the current build completes.

Generated by :no_entry_sign: dangerJS

DrewML commented 6 years ago

If you're going to write unit tests for ensureDirURI, consider adding one for the case where uri already ends with /.

Good call - added