Refactor Peregrine to be a plain class

magento-research / peregrine

(Defunct) Moved to https://github.com/magento-research/pwa-studio

Open Software License 3.0

29 stars 1 forks source link

Closed jimbo closed 6 years ago

jimbo commented 6 years ago

Rather than being a React Component class, Peregrine needs to be a plain class.

A given component should be able to import the app instance and interact with it via methods
Methods should have an async signature and assume they're dealing with dynamically imported modules

DrewML commented 6 years ago

CI should be fixed in this branch after rebasing off the latest master

DrewML commented 6 years ago

From CI:

Forgot to run prettier? There are files without correct code style:
src/index.js

jimbo commented 6 years ago

Too controversial. Closed in favor of #10.