search

magento / adobe-stock-integration

Magento Adobe Stock integration Community Project.
Open Software License 3.0
60 stars 92 forks source link

Fix error when saving image from stock that does not have Category #1847

Closed engcom-Golf closed 4 years ago

engcom-Golf commented 4 years ago

Description (*)

Fixes error that is thrown on saving asset with no category (category_id=0)

Fixed Issues (if relevant)

  1. Fixes magento/adobe-stock-integration#1846: Error when saving image from stock that does not have Category
  2. If there was no category - empty value was saved in database table adobe_stock_category

Manual testing scenarios (*)

  1. Open Adobe Stock Panel from Media Gallery
  2. Search for "Distant deer in a misty forest"
  3. In the search results find an image with category "None"
  4. Save Preview
  5. Check saved image details (Adobe Stock section should be displayed correctly, pay attention to Category)

Expected result (*)

Image is saved successfully, no errors appear

Actual result (*)

Image is saved but an error appears "An error occurred during adobe stock asset save."

engcom-Golf commented 4 years ago

@magento run all tests

engcom-Golf commented 4 years ago

@magento run all tests

engcom-Bravo commented 4 years ago

:heavy_check_mark: QA Passed

Successfully saved an Image without Category from Adobe Stock The displayed Category is None in Image Details page cat_none

Checked saving into Old Media Gallry cat_none_old

Added a Manual Testing Scenario on Cucumber - https://studio.cucumber.io/projects/131313/test-plan/folders/943908/scenarios/5239787

ghost commented 4 years ago

Hi @engcom-Golf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.