search

magento / adobe-stock-integration

Magento Adobe Stock integration Community Project.
Open Software License 3.0
60 stars 92 forks source link

Release tag 2.1.2 missing #1871

Open Vinai opened 2 years ago

Vinai commented 2 years ago

Preconditions (*)

  1. The package magento/product-community-edition 2.4.3 requires "magento/adobe-stock-integration": "2.1.2"
  2. This repository https://github.com/magento/adobe-stock-integration/ does not contain a tag 2.1.2, only 2.1.2-p1
  3. This repository does have a branch 2.1.2, but branches are not supposed to be used as a target dependency in a release, since they do not point to a specific commit.

Expected result (*)

  1. That it is possible to resolve the dependencies of magento/product-community-edition manually by visiting the source repositories and selecting the tagged release version

Actual result (*)

  1. The dependency on magento/adobe-stock-integration version 2.1.2 can not be accurately resolved manually.
m2-assistant[bot] commented 2 years ago

Hi @Vinai. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this

Vinai commented 2 years ago

Suggested solution:

  1. rename the 2.1.2 branch to 2.1.2-develop or something, so the 2.1.2 ref does not conflict with the tag
  2. check out to the commit that was used to build the 2.1.2 release package (possibly that is the 2.1.2 branch?), create a tag 2.1.2, and push the tag
danslo commented 2 years ago

@sidolov Could you please take a look at this?