magento / adobe-stock-integration

Magento Adobe Stock integration Community Project.
Open Software License 3.0
60 stars 92 forks source link

Ensure MFTF tests ensure Adobe Stock credentials are in place in their `before` setup #651

Closed filmaj closed 5 years ago

filmaj commented 5 years ago

Is your feature request related to a problem? Please describe. Not all MFTF tests in the repo ensure appropriate Adobe Stock API credentials are in place before the test executes. The question is: should they? I think the tests that rely on actual Adobe Stock Integration functionality from Adobe Stock should. We do have some tests (like the basic set up tests) that do NOT rely on these preconditions, and thus, should not include this.

Describe the solution you'd like

Describe alternatives you've considered We could simply ignore this and assume credentials are in place before test execution, but I think that is brittle. Plus, we already have ActionGroups that define the functionality of checking and putting into the configuration the credentials, so I think we should ensure the proper preconditions are in place.

Additional context See e.g. https://github.com/magento/adobe-stock-integration/pull/633/files#diff-4059dec71a4278a186ce65477dfd66c7R22 for an example of a proper credential precondition being in place in the test.

filmaj commented 5 years ago

Nevermind, another derp by me: this is covered by tagging tests with the adobe_stock_integration group name which will then assign it to the appropriate Suite, which includes setting up the credentials appropriately. https://github.com/magento/adobe-stock-integration/blob/develop/AdobeStockImageAdminUi/Test/Mftf/Suite/adobe-stock-integration.xml#L14

I'm on a roll of filing issues pointlessly today, weeeeee.