magento / adobe-stock-integration

Magento Adobe Stock integration Community Project.
Open Software License 3.0
60 stars 92 forks source link

Add "Unlicensed" overlay to media gallery grid #830

Closed sivaschenko closed 4 years ago

sivaschenko commented 4 years ago

See more information in the story:

https://github.com/magento/adobe-stock-integration/issues/460

Preconditions

  1. Install Magento with Adobe Stock Integration
  2. Save at least one Adobe Stock image preview to media gallery

Steps to reproduce (*)

  1. Login to Admin Panel
  2. Select "Media Gallery Development" from the menu on the right

Actual result (*)

Images do not include any overlay labels:

image

Expected result (*)

Images that are saved from Adobe Stock and are not licensed should have "Unlicensed" red overlay label:

image

filmaj commented 4 years ago

To clarify, preconditions here include:

Is the above correct?

sivaschenko commented 4 years ago

@filmaj the second precondition is correct. The first one is not - the information about unlicensed assets in media gallery should be retrieved from Magento database (not from API as on Adobe Stock grid) so the login is not required.

Preconditions are updated accordingly

filmaj commented 4 years ago

Just a point of clarification: is the licensed/unlicensed DB field implemented already or does that still need to be implemented? And if so, which issue is that tracked in?

sivaschenko commented 4 years ago

@filmaj the source field is adobe_stock_asset.is_licensed (already there)