search

magento / architecture

A place where Magento architectural discussions happen
275 stars 153 forks source link

B2B NegotiableQuote GraphQL Schema #381

Closed G-Arvind closed 4 years ago

G-Arvind commented 4 years ago

Problem

Coverage for B2B Negotiable quotes

Solution

Schema for B2B Requisition List

Queries

Mutations

Requested Reviewers

G-Arvind commented 4 years ago

Please address outstanding comments, after that another round of review will be required. Thank you

@paliarush @DrewML thank you so much for your valuable comments. I have addressed them can you guys please have a look at it. Thanks.

DrewML commented 4 years ago

Thanks for all the hard work so far @G-Arvind - we appreciate it 😄.

I'll try to give this another read through today.

DrewML commented 4 years ago

@kokoc

I think negotiable quote is an addition to our existing cart

I'll lean on you for that since I know very little about B2B, but I get the same impression from reading the docs.

Seems like you can't create a negotiable quote without a cart. In other words, a negotiable quote has a cart, which a field of type Cart would model well.

Because of the previous point, quotes should have a name

Think this highlights that the current schema in this PR is missing display name - it should be present for the UI regardless of whether there's one or several.

tl;dr: makes sense to me 👍

G-Arvind commented 4 years ago

Hi @paliarush Thanks for the comments, I addressed all the comments and pushed the latest schema. Regarding proceed to checkout, can we create a mutation that accepts quote id as the input and transfers all the items to a cart? Please advise. Thanks

DrewML commented 4 years ago

Hey @G-Arvind!

Thanks you again for the great work on this! As @nrkapoor mentioned elsewhere, we took this schema and used it as an excellent basis and made some improvements to it internally, since we didn't want you to have to keep going back and forth on Github comments.

I'm going to merge this PR and then open up a follow-up PR with additional changes. We'd welcome any feedback you have.

Thanks again!

G-Arvind commented 4 years ago

Hey @G-Arvind!

Thanks you again for the great work on this! As @nrkapoor mentioned elsewhere, we took this schema and used it as an excellent basis and made some improvements to it internally, since we didn't want you to have to keep going back and forth on Github comments.

I'm going to merge this PR and then open up a follow-up PR with additional changes. We'd welcome any feedback you have.

Thanks again!

Thank you so much @DrewML :slightly_smiling_face: