Closed danielrenaud closed 4 years ago
I would suggest adding CommentItem
also for credit memo and shipment types.
I would suggest adding
CommentItem
also for credit memo and shipment types.
For CreditMemo and Shipment, there is ability to add comment on backend but no option to make it visible on storefront. So seems like we shouldn't show it on storefront
EDIT: Nevermind; it depends on if you are creating or editing. So, we will add comments to those types.
Made additional changes. Added comments to CreditMemo and OrderShipment types Change CustomerOrder.carrier, method, and shipping_address to be nullable because it is possible for these to be empty for an order (e.g. order with only virtual products)
Do you have any screenshots of what the UI for this data looks like (or plans to look like)? We've got a backlog of schemas to review right now and would help us to make things speedier
@DrewML In Luma if you login as a customer and go to "My Orders" (place some orders first), that is the UI that this is roughly based on.
@DrewML In Luma if you login as a customer and go to "My Orders" (place some orders first), that is the UI that this is roughly based on.
Sure! I'm just asking that we include some screenshots since there will be more reviewers (few of us reviewing > 10 schemas in a rush atm). Lots of schemas covering tons of different areas, definitely easier if examples are readily accessible.
Here is a collection of screenshots from the UI we are referencing for this schema.
Thanks @danielrenaud - that's super helpful!
changed order_item_id: String
to order_item: OrderItemInterface
for InvoiceItem /CreditMemoItem / ShipmentItem
We have approvals across the board on this, so I'm going to go ahead and merge.
@cpartica @danielrenaud if we're still iterating please feel free to open new PRs and we'll try to make it through them fast.
Problem
Solution
Other changes: Add
comments
field to Order and InvoiceRequested Reviewers
@joni-jones @akaplya @paliarush