search

magento / architecture

A place where Magento architectural discussions happen
274 stars 154 forks source link

Order Address type is added for shipping and billing address on orders #401

Closed avattam06 closed 4 years ago

avattam06 commented 4 years ago

Problem We have some fields like default_shipping, default_billing, and extension attributes on the 'CustomerAddress' type, which are not required on the orders schema. So it is better to create a new address type for orders with the necessary fields.

Solution Proposing a new 'OrderAddress' type for shipping and billing address for the order on the customer orders mutation

Requested Reviewers @nrkapoor @paliarush @joni-jones

DrewML commented 4 years ago

Great work @avattam06! Few small comments, but looks great overall

avattam06 commented 4 years ago

The team is planning to add some more changes to 'PaymentMethod' and 'CommentItem' namespaces as @paliarush suggesting. We will add those changes too in this PR and then we can merge this.

DrewML commented 4 years ago

@avattam06 Sounds good - I'll hold off on merging for now

avattam06 commented 4 years ago

@avattam06 Sounds good - I'll hold off on merging for now

The team decided to cover it on a new PR, thanks for waiting @DrewML, you can merge it now.