search

magento / architecture

A place where Magento architectural discussions happen
275 stars 153 forks source link

Propose changes to field types in Add Products to cart mutations #412

Closed prabhuram93 closed 4 years ago

prabhuram93 commented 4 years ago

Problem

  1. Changes need to be propagated from these 2 PRs https://github.com/magento/architecture/pull/396, https://github.com/magento/architecture/pull/395

Solution

  1. Update id field types from String! to ID!
  2. If a new mutation is expected to use encoded ids, then name it uid

Requested Reviewers

@paliarush @DrewML