magento / architecture

A place where Magento architectural discussions happen
275 stars 153 forks source link

Update GraphQl company create mutation output #423

Closed munkhulzii closed 4 years ago

munkhulzii commented 4 years ago

Problem

The type of CreateCompanyOutput for company create mutation is defined as type "Company". The fields of Company in current implementation have their own resolver in which the authorization will be checked. It would fail for creating company because in this case we do not have a logged in user.

Solution

Update schema with base fields like the response for company registration in frontend. No additional fields like "role", "users", "structure" etc.

Requested Reviewers

@paliarush @cpartica @danielrenaud

melnikovi commented 4 years ago

Decided to not modify CreateCompanyOutput type.