magento / architecture

A place where Magento architectural discussions happen
275 stars 153 forks source link

AEM uid updates #424

Closed DrewML closed 4 years ago

DrewML commented 4 years ago

Problem

The AEM team gave us a list of fields they want us to fix in accordance with our ID Improvement Plan.

Solution

Apply the schema changes from the ID Improvement Plan, for now just in the places flagged as high priority for AEM.

The request list is:

CartItemUpdateInput.cart_item_id RemoveItemFromCartInput.cart_item_id CartItemQuantity.cart_item_id CategoryInterface.id and Query.category(id: Int) ProductInterface.id Breadcrumb.category_id Customer.id

Note that CartItemQuantity is already deprecated in core, so that field was skipped. It was only used in cart_items fields, but there is now a cart_items_v2 that returns CartItemInterface instead (which is updated as part of this PR).

Notes

The schemas we're changing were not fully present in this repository, so I copied over up-to-date copies from 2.4-develop.

I split up my commits between changes and code copying to make it easier to review. See the Commits tab to aid your review

This link should include all the commits in a diff, without the code copying.

Requested Reviewers

@melnikovi @nrkapoor