magento / catalog-storefront

Open Software License 3.0
7 stars 18 forks source link

Return rating title in ProductReviews service #464

Open magento-engcom-team opened 3 years ago

magento-engcom-team commented 3 years ago

In the current implementation, we return rating_id and rating_value. 

It's necessary to return the rating title as well to be used on the storefront. 

repo: https://github.com/magento/storefront-product-reviews-ce/

Extend Rating message with "name" value and use in \Magento\ReviewsStorefront\Model\ProductReviewsServer::getProductReviews method

message Rating {
  string rating_id = 1;
  string value = 2; 
  string name = 3; // new field
}

 

magento-engcom-team commented 3 years ago

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/SFAPP-181

m2-assistant[bot] commented 3 years ago

Hi @magento-engcom-team. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


RakeshJesadiya commented 3 years ago

@magento I am working on this.

RakeshJesadiya commented 3 years ago

I am facing issue on the Grpc UI for the review storefront. Request payload is Product Id 1 and store code is default, request-review

Output has an error, response

Is this known bug to storefront review repo?

FYI @kandy @mslabko