Improve Price Book scope validation

magento / catalog-storefront

Open Software License 3.0

7 stars 18 forks source link

Improve Price Book scope validation #472

Open lykhachov opened 3 years ago

lykhachov commented 3 years ago

Current approach can lead to performance problems during PR creation with big amoun of price books

Method: \Magento\PricingStorefront\Model\PriceBookRepository::validatePriceBookUnique.

Investigate options to improve this. For example, we can utilize "JSON" type for and replace existing website/customer_group columns with new column "scopes" with the following structure: {"w": [...], "cg": [...]}, index for both fields should be created

m2-assistant[bot] commented 3 years ago

Hi @lykhachov. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

mslabko commented 3 years ago

@magento export issue to Jira project SFAPP as Task

magento-engcom-team commented 3 years ago

:white_check_mark: Jira issue (https://jira.corp.magento.com/browse/SFAPP-190) is successfully created for this issue.