search

magento / catalog-storefront

Open Software License 3.0
7 stars 18 forks source link

Unify price event provider event data formation. #474

Open bricht opened 3 years ago

bricht commented 3 years ago

The price event data providers contain some duplicate code. Specifically buildEventData functions in FullReindex and PartialReindex providers. For example \Magento\CatalogPriceDataExporter\Model\Provider\FullReindex\CustomOptionPriceEvent::buildEventData and \Magento\CatalogPriceDataExporter\Model\Provider\PartialReindex\CustomOptionPriceEvent::buildEventData are the same.

We need to bring this logic out of the providers in order to avoid code duplication.

Related to https://github.com/magento/catalog-storefront/issues/465

m2-assistant[bot] commented 3 years ago

Hi @bricht. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

mslabko commented 3 years ago

@magento export issue to Jira project SFAPP as Story

magento-engcom-team commented 3 years ago

:white_check_mark: Jira issue (https://jira.corp.magento.com/browse/SFAPP-197) is successfully created for this issue.

RakeshJesadiya commented 3 years ago

@mslabko @bricht Which repo contains the Class CustomOptionPriceEvent.php defined in the issue? Thank you.

bricht commented 3 years ago

@mslabko @bricht Which repo contains the Class CustomOptionPriceEvent.php defined in the issue? Thank you.

https://github.com/magento/commerce-data-export/pull/21/files#diff-ba1939c8004a571b5cb8c76346ab6b6a96427eb9ae468b637174954c486a83f8

RakeshJesadiya commented 3 years ago

When the CatalogPriceDataExporter module will be merged? FYI @bricht

RakeshJesadiya commented 3 years ago

@magento I am working on this

RakeshJesadiya commented 3 years ago

@mslabko @bricht Please check the PR, https://github.com/magento/commerce-data-export/pull/23