[17] Read API :: Integration tests :: Magento.StorefrontGraphQl

mslabko commented 4 years ago

In the scope of delivery #17 need to fix integration tests Magento.StorefrontGraphQl*:

Needed branches:

CE: https://github.com/magento/magento2/tree/2.4-develop
EE https://github.com/magento/partners-magento2ee/tree/2.4-develop
Catalog storefront CE: https://github.com/magento/catalog-storefront/tree/api-proto
Catalog storefront EE: https://github.com/magento/catalog-storefront-ee/tree/api-proto

List of tests: Magento.StorefrontGraphQl.Model.Query.ScopeProviderTest.testGetScopesWithoutStore Magento.StorefrontGraphQl.Model.Query.ScopeProviderTest.testGetScopesWithoutGroupId Magento.StorefrontGraphQl.Model.Query.ScopeProviderTest.testGetScopesWithoutStore Magento.StorefrontGraphQl.Model.Query.ScopeProviderTest.testGetScopesWithoutGroupId

Example of error: Magento.StorefrontGraphQl.Model.Query.ScopeProviderTest.testGetScopesWithoutStore (from Magento_StorefrontGraphQl_Model_Query_ScopeProviderTest)

Failing for the past 1 build (Since Failed#4745 ) Took 9 ms. Stacktrace Magento\StorefrontGraphQl\Model\Query\ScopeProviderTest::testGetScopesWithoutStore Magento\Framework\GraphQl\Exception\GraphQlNoSuchEntityException: There is no store in extension attributes

/var/www/html/app/code/Magento/StorefrontGraphQl/Model/Query/ScopeProvider/StoreScope.php:29 /var/www/html/app/code/Magento/StorefrontGraphQl/Model/Query/ScopeProvider.php:49 /var/www/html/dev/tests/integration/testsuite/Magento/StorefrontGraphQl/Model/Query/ScopeProviderTest.php:107

Dev notes:

some classes in catalog-storefront repo are autogenerated (marked as "Generated by the Magento PHP proto generator. DO NOT EDIT!") If you still need to edit them to fix test, please mention it in the comment

m2-assistant[bot] commented 4 years ago

Hi @mslabko. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

skovalenk commented 4 years ago

Fixed here: https://github.com/magento/catalog-storefront/pull/77

mslabko commented 4 years ago

@skovalenk 77 PR targeted to "develop" branch, but we are working in scope of #17 issue and we are fixing api-ptoto branch (please, see description)

Also, I've tested locally test from https://github.com/magento/catalog-storefront/pull/77 PR and see the same errors:

root@app:/var/www/magento2ce/dev/tests/integration#  ../../../vendor/bin/phpunit -c /var/www/magento2ce/dev/tests/integration/phpunit.xml.dist testsuite/Magento/CatalogStorefront/Model/Storage/ClientAdapterTest.php 
PHPUnit 9.1.5 by Sebastian Bergmann and contributors.

Warning:       Using a custom test suite loader is deprecated

EEEEE                                                                                                                                                                                       5 / 5 (100%)

Time: 00:57.733, Memory: 44.00 MB

There were 5 errors:

1) Magento\CatalogStorefront\Model\Storage\ClientAdapterTest::testBulkInsert
Magento\Framework\Exception\CouldNotSaveException: Error occurred while saving 'catalog_storefront_v1_scope' index.

/var/www/catalog-storefront/app/code/Magento/CatalogStorefront/Model/Storage/Client/ElasticsearchDataDefinitionAdapter.php:67
/var/www/catalog-storefront/dev/tests/integration/testsuite/Magento/CatalogStorefront/Model/Storage/ClientAdapterTest.php:85

Caused by
Elasticsearch\Common\Exceptions\NoNodesAvailableException: No alive nodes found in your cluster

mslabko commented 4 years ago

@skovalenk locally this tests is also passed, but in some reason it fails on Jenkins:

Magento\CatalogStorefront\Model\Storage\ClientAdapterTest::testNotFoundIndex
Magento\Framework\Exception\NotFoundException: 'product' type document with id '111' not found in index 'not_found_index'.

/var/www/html/app/code/Magento/CatalogStorefront/Model/Storage/Client/ElasticsearchQuery.php:86
/var/www/html/dev/tests/integration/testsuite/Magento/CatalogStorefront/Model/Storage/ClientAdapterTest.php:170

magento / catalog-storefront

[17] Read API :: Integration tests :: Magento.StorefrontGraphQl #63