magento / catalog-storefront

Open Software License 3.0
7 stars 18 forks source link

gRPC compatibility with new APIs #80

Open mslabko opened 4 years ago

mslabko commented 4 years ago

As a developer, I want to expose my APIs using gRPC protocol which provides unprecedented performance.

Since gRPC compatible interfaces/classes are generated using an external tool, code generation from https://github.com/magento/module-grpc should be eliminated.

AC:

Note: need to check if this story is in progress by performance team.

m2-assistant[bot] commented 4 years ago

Hi @mslabko. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


kokoc commented 4 years ago

Notes:

mslabko commented 4 years ago

What needs to be done to have gRPC communication between GQL & SF API

mslabko commented 4 years ago

We can use docker image "zabaz/php:7.4-proto" which come with "protobuf" extension

But I think this is not required for test porpouse:

To achieve higher performance on larger messages, make sure to install a protobuf extension for PHP.
mslabko commented 4 years ago

Closed in favor of https://jira.corp.magento.com/browse/SFAPP-77