27 product variants - Githubissues

RuslanKostiv1 commented 4 years ago

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes https://github.com/magento/catalog-storefront/issues/431

Questions or comments

Code Review Checklist (*)

See detailed checklist

[ ] Story AC is completed
[ ] proposed changes correspond to Magento Technical Vision
[ ] new or changed code is covered with web-api/integration tests (if applicable)
- expected results in test verified with data from fixture
[ ] no backward incompatible changes
[ ] Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
- prerequisite: story branch created with all needed generated classes according to proposes schema-changes
- DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
[ ] Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
- Check composer.json dependencies
[ ] Legacy code is deleted
- Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
- And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
- Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
- Any “mapper” on Message Broker (between Export API and SF API)
- if mapper still needed, verify fields used in mapping, remove not relevant fields

bricht commented 4 years ago

@magento run all tests

bricht commented 4 years ago

@magento run WebAPI Tests

bricht commented 4 years ago

@magento run Static Tests

bricht commented 4 years ago

@magento run all tests

bricht commented 4 years ago

@magento run WebAPI Tests

bricht commented 4 years ago

@magento run Static Tests

bricht commented 4 years ago

@magento run WebAPI Tests

bricht commented 4 years ago

@magento run WebAPI Tests

bricht commented 4 years ago

@magento run WebAPI Tests

RuslanKostiv1 commented 4 years ago

@magento run all tests

RuslanKostiv1 commented 4 years ago

@magento import pr to magento-commerce/commerce-data-export

magento-engcom-team commented 4 years ago

@RuslanKostiv1 the pull request successfully imported.

RuslanKostiv1 commented 4 years ago

@magento run all tests

bricht commented 3 years ago

@magento run all tests

bricht commented 3 years ago

@magento run WebAPI tests

bricht commented 3 years ago

@magento run WebAPI Tests

bricht commented 3 years ago

@magento run all tests

magento / commerce-data-export

27 product variants #11

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Questions or comments

Code Review Checklist (*)