search

magento / community-features

Magento Features Development is an Initiative to Allows Community Memebers Join to Development of Magento Features
46 stars 18 forks source link

magentoDataFixture should allow to use Module Prefix - Integrations Test #113

Closed larsroettig closed 5 years ago

larsroettig commented 5 years ago

Description (*)

As a Developer, we have different solutions to install Magento and Setup Projects. Currently, if the test fixtures place in the app/code/Module_Name and is installed over composer is not possible to use annotations like Magento_InventoryApi::Test/_files/products.php

Expected behavior (*)

Module annotations like Magento_InventoryApi::Test/_files/products.php works and \Magento\TestFramework\Annotation\DataFixture find the correct path for Integrations Test

Benefits

As a developer, you can use the prefix to use data fixture from the core to test your own plugins and extensions

Additional information

    /**
     * Old Fixture File place in testsuite
     * @magentoDataFixture Magento/Customer/_files/customer.php
     *
     * New Fixture File place in app/code
     * @magentoDataFixture Magento_InventoryApi::Test/_files/products.php
     *
     * @magentoDbIsolation disabled
     */
    public function testValidation()
magento-engcom-team commented 5 years ago

Hi @larsroettig. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop). For more details, please, review the Magento Contributor Assistant documentation.

@larsroettig do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

sdzhepa commented 5 years ago

Hello @larsroettig

According to the label "feature request" that you have set, I am moving this ticket into Feature Request track

Thank you

magento-engcom-team commented 5 years ago

Hi @larsroettig. Thank you for your report. The issue has been fixed in magento/magento2#19679 by @larsroettig in 2.3-develop branch Related commit(s):

The fix will be available with the upcoming 2.3.2 release.