magento / community-features

Magento Features Development is an Initiative to Allows Community Memebers Join to Development of Magento Features
46 stars 18 forks source link

Magento_Rss and Magento_Wishlist can't be disabled. #203

Open Hexmage opened 5 years ago

Hexmage commented 5 years ago

Summary

The Magento_Rss module can't be disabled because the Magento_Wishlist depends on it. Disabling the Magento_Wishlist is impossible, because Magento_Sales, Magento_Customer, Magento_Reports and Magento_Catalog all depend on the Wishlist. These dependencies feel reversed. Sales, Customer and Catalog (and to a lesser extend Reports) are the more crucial parts of Magento and should work without the Wishlist or Rss functionalities.

Examples

bin/magento module:disable Magento_Rss or bin/magento module:disable Magento_Wishlist will list about 60 modules that depend on both of these modules.

Steps to Reproduce

  1. Try to disable module Magento_Rss (run php bin/magento module:disable Magento_Rss)

Expected Result

Thee module is successfully disabled or at least it demands disabling of some other not too essential dependent modules before letting disable itself.

Actual Result

The module requires disabling too many modules including the most essential ones such as Catalog, Sales, Customer.

Proposed solution

The logic that controls the Wishlist Rss Feed should be moved to it's own module (Magento_Rss_Wishlist). Because this will remove the direct dependency between Rss and Wishlist and make the modules more flexible. The Wishlist module should depend on the Sales, Customer and Catalog modules instead of the other way around. This would mean moving all the wishlist specific code from these modules to the Wishlist module. For the Reports module I would suggest Magento_Reports_Wishlist being its own module to remove the direct dependencies, for the same reason as Magento_Rss_Wishlist.

m2-assistant[bot] commented 5 years ago

Hi @Hexmage. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Hexmage do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?


m2-assistant[bot] commented 5 years ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Bravo commented 5 years ago

Hello @sdzhepa. This issue looks more like a feature request. Will you please transfer it to the feature requests repository. Thank You.

m2-assistant[bot] commented 5 years ago

Hi @sdzhepa. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

hostep commented 4 years ago

Slightly related issue: https://github.com/magento/magento2/issues/22084 (if that one is also considered a feature request feel free to close it as a duplicate of this one, even though it was more of a regression introduced in Magento 2.3.1 ...)