InstallSchema likes Vendor\Namespace but does not like Vendor\Name\Space

tylers-username commented 4 years ago

Environment

Magento 2.2

Summary (*)

First, I chose not to report this as a bug because it could just be me not following PSR-4 best practices. So, let's communicate about it first.

When Magento checks for InstallSchema it does not honor the composer-configured PSR-4 root.

Examples (*)

If I set my composer.json to the config below, it is honored by Composer and Magento. However, it is not honored for setup scripts when magento setup:module is attempting to discover them
```
"autoload": {
"psr-4": {
  "Vendor\\Name\\Space\\": ""
},
}
```
If I set my composer.json to the normal/popular config below, it is honored by Composer and Magento and the scripts are found during setup:upgrade
```
"autoload": {
"psr-4": {
  "Vendor\\Namespace\\": ""
},
}
```
Proposed solution

Have Magento's setup:upgrade logic consider the Composer-configured PSR-4 namespace root.

m2-assistant[bot] commented 4 years ago

Hi @tylerssn. Thank you for your report. To help us process this issue please make sure that you provided the following information:

[x] Summary of the issue
[x] Information on your environment
[x] Steps to reproduce
[x] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@tylerssn do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

[x] yes
[ ] no

Join Magento Community Engineering Slack and ask your questions in #github channel.

tylers-username commented 4 years ago

I understand my want for assigning a root namespace for my package such as Vendor\Name\Space is rare and, for my use-case, I only intend on having a few packages modeled this way. So, is this worth bug reporting over or is this expected behavior based on PSR-4 best practices?

m2-assistant[bot] commented 4 years ago

Hi @engcom-Charlie. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

m2-assistant[bot] commented 4 years ago

Hi @sdzhepa. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Charlie commented 4 years ago

Hello @sdzhepa This issue looks like a feature request. Please transfer this issue to community features repository.

magento / community-features