magento / community-features

Magento Features Development is an Initiative to Allows Community Memebers Join to Development of Magento Features
46 stars 18 forks source link

CI: Validate i18n coverage #244

Open lbajsarowicz opened 4 years ago

lbajsarowicz commented 4 years ago

Summary (*)

Currently when new PR introduces new Phrase to be translated, it's very uncommon to remember about adding the phrase to i18n/en_US.csv.

Examples (*)

Proposed solution

This would be useful to have Static Analysis Tool that verifies if Contributor haven't introduced new phrase that was not covered in i18n, and after some time - require to have all phrases from modified files in proper i18n.

magento-deployment-service[bot] commented 4 years ago

Thanks for opening this issue!

m2-assistant[bot] commented 4 years ago

Hi @lbajsarowicz. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@lbajsarowicz do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?


rogyar commented 4 years ago

+1 That's really nice to have

m2-assistant[bot] commented 4 years ago

Hi @engcom-Hotel. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

engcom-Hotel commented 4 years ago

Hello @sdzhepa This issue looks like feature request. Could you transfer this issue to the Magento Feature requests repository?

Thanks for collaboration!

m2-assistant[bot] commented 4 years ago

Hi @sdzhepa. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down: