Create static test for action controllers

lenaorobei commented 4 years ago

Description (*)

Due to recent changes in https://github.com/magento/magento2/pull/26778#issuecomment-592766350 need to create static test that will check that controller classes implement ActionInterface and do not extend Action abstract class.

Expected behavior (*)

Static check fails if controller class extends Action.

Benefits

This will prevent using of deprecated ActionInterface.

m2-assistant[bot] commented 4 years ago

Hi @lenaorobei. Thank you for your report. To help us process this issue please make sure that you provided the following information:

[ ] Summary of the issue
[ ] Information on your environment
[ ] Steps to reproduce
[ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@lenaorobei do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

[ ] yes
[ ] no

Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] commented 4 years ago

Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Bravo commented 4 years ago

@sdzhepa Can you please transfer this feature request to the appropriate repository?

Thank you in advance

sdzhepa commented 4 years ago

@lenaorobei cc: @engcom-Bravo Could you please clarify is it really new feature request or bug that should be fixed?

sdzhepa commented 4 years ago

Hello @lenaorobei

Thank you for feedback and your proposal!

Based on the description and label feature request the issue has been transferred to Magento Feature Request public repo.

swnsma commented 4 years ago

Hi @lenaorobei, Could you please clarify next:

test must works only for files related to a PR;
test must works only for created files and ignore modified files; Am I right?

naydav commented 4 years ago

Hi @lenaorobei, Could you please clarify next:

test must works only for files related to a PR;

test must works only for created files and ignore modified files; Am I right?

Hi @swnsma,

Sorry for the misunderstanding but the final decision about the controllers is still in active discussion. Thus, this task is not ready for development.

lenaorobei commented 3 years ago

Hi @swnsma, Sorry for the delay. Answering your questions.

test must works only for files related to a PR

Yes

test must work only for created files and ignore modified files;

Yes, you are right.

Thanks a lot for working on this.

swnsma commented 3 years ago

Here we go: https://github.com/magento/magento2/pull/29339

ihor-sviziev commented 3 years ago

https://github.com/magento/magento2/pull/26778 was already merged, so basically we have such static test. @lenaorobei @naydav @sdzhepa could you close this issue?

lenaorobei commented 3 years ago

@ihor-sviziev yes, sure!

Thanks again @swnsma! That's a great improvement.

magento / community-features