Color doesn't apply to Visual Swatches by clicking on page

Usik2203 commented 4 years ago

Preconditions (*)

Steps to reproduce (*)

1.Go to Store -> Attributes -> Product -> Add New Attribute 2.Choose Visual Swatch 3.Add Swatch 4.Choose color

Click on the page

Expected result (*)

We have chosen color and click on page and color was applied.

Actual result (*)

We had to click button on colorpicker panel. It can confuse customers 2020-03-24 21 25 23

2020-03-24 21 27 38

m2-assistant[bot] commented 4 years ago

Hi @Usik2203. Thank you for your report. To help us process this issue please make sure that you provided the following information:

[ ] Summary of the issue
[ ] Information on your environment
[ ] Steps to reproduce
[ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Usik2203 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

[ ] yes
[ ] no

Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] commented 4 years ago

Hi @ajijshekh123. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

ajijshekh123 commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @ajijshekh123, here is your Magento instance. Admin access: https://i-27418-2-4-develop.instances.magento-community.engineering/admin_d34b Login: 6a0f9d53 Password: 235b7a3cfccd Instance will be terminated in up to 3 hours.

ajijshekh123 commented 4 years ago

Hello @Usik2203, This is not an issue. I think this is a default pick color feature. Please update your thought here.

Thanks.

Usik2203 commented 4 years ago

Hello @ajijshekh123 Yes, it's not issue , but perhaps it can be little future. We choose color and we have to click this button for applying color.

But maybe we can add ability apply color by clicking on the page. Without clicking button inside colorpicker. It just idea. I think it makes sense

Thanks

ajijshekh123 commented 4 years ago

Okay @Usik2203 , Let me add Magento QA and Update it to you.

Thanks.

m2-assistant[bot] commented 4 years ago

Hi @sdzhepa. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

ajijshekh123 commented 4 years ago

@sdzhepa - Can you please update your thought here?

VZeroCool commented 4 years ago

@magento give me 2.4-develop instance

magento-engcom-team commented 4 years ago

Hi @VZeroCool. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @VZeroCool, here is your Magento instance. Admin access: https://i-27418-2-4-develop.instances.magento-community.engineering/admin_a714 Login: 2d7c2723 Password: ff44305a05e6 Instance will be terminated in up to 3 hours.

m2-assistant[bot] commented 4 years ago

Hi @niravkrish. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Join Magento Community Engineering Slack and ask your questions in #github channel.

sdzhepa commented 4 years ago

Hello @aredridel

Thank you for feedback and your proposal!

Based on the description and discussion, the issue has been transferred to Magento Feature Request public repo.

Additionally, based on Issue reporting guidelines feel free to raise this topic on the next resources:

Before creating an issue, please do the following: ...

Make sure, that information you are about to report is a technical issue, please refer to the Community Forums or Magento Stack Exchange for technical questions, feature requests, etc. These reports are not guaranteed to be processed within GitHub issue tracker.

niravkrish commented 4 years ago

I have added this functionality. Please review below PR. https://github.com/magento/magento2/pull/27461

magento / community-features