magento / community-features

Magento Features Development is an Initiative to Allows Community Memebers Join to Development of Magento Features
46 stars 18 forks source link

newsletter subscription confirmation link single time use time #275

Open tulumc opened 4 years ago

tulumc commented 4 years ago

@magento I am working on this this is my first report/feature request I hope this is correct.

I'm on Mangeto 2.3.5-p1 and working on a Customised subscription module for newsletters, and found that the confirmation link send to a newsletter subscriber can be used multiple times. I don't now if this is a Problem for most use cases, a bug, or a feature that is not implemented so I don't now if this belongs here.

it would be nice when this could be a single use link or a little check if the user is already subscribed.

also would this be correct if I would implement it in a module I would copy the content of module-newsletter/Controller/Subscriber/Confirm.php and only change this if ($subscriber->confirm($code)) { in to this if ($subscriber->confirm($code) && $subscriber->getStatus() != Subscriber::STATUS_UNCONFIRMED) {

m2-assistant[bot] commented 4 years ago

Hi @tulumc. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


tulumc commented 4 years ago

I updated my original empty comment hope this is correct

(this was my first Report and comment so I don't now if you get an alert when my original comment gets updated)

A big THANK YOU to the Magento team for the amazing work