magento / community-features

Magento Features Development is an Initiative to Allows Community Memebers Join to Development of Magento Features
46 stars 18 forks source link

ambiguity for cleanup-database option for M2 installation from CLI #32

Open magento-engcom-team opened 6 years ago

magento-engcom-team commented 6 years ago

All options for CLI have a predefined value, or are booleans and are solvable by 1/0. This particular option has none and is activated only by its simple presence, as documented here:

To drop database tables before installing the Magento software, specify this parameter without a value. Otherwise, the Magento database is left intact.

In order to automate the installation (for example using Ansible, but this is by no means required), one wants to loop through all installation options, get their given/default values and create the full install string for CLI without having special cases like the one above. For consistency sake is better to have all options with predefined values, than doing decision only based on the presence of the parameter.

Preconditions

  1. Magento CLI version 2.1.3

Steps to reproduce

N/A.

Expected result/proposal

Have a default value of 0, that will not drop the databases, and with value of 1 to drop.

Original Report: https://github.com/magento/magento2/issues/8471 by @valugi