magento / community-features

Magento Features Development is an Initiative to Allows Community Memebers Join to Development of Magento Features
46 stars 18 forks source link

Upload .SVG to Magento Media Gallery #51

Open tkacheva opened 6 years ago

tkacheva commented 6 years ago

Originally recorded in MAGETWO-53778 Requires Merchant Documentation: Yes

Proposed Release Note:

This feature allows merchants to upload SVG file into Magento Media Gallery and use it in the content. Before this feature only developers were able to use .svg

Card:

As a Content manager I want to upload SVG file into Magento Media Gallery so that I use it the webstore content

Background:

SVG is not supported in Magento since 2.2 release because of potential security violations (MAGETWO-61189) that assumes JS code can be inserted inside SVG file. Since that there was several issues reported on GitHub:

SVG format grows its popularity and this trend shows that enterprise level of websites use it more often that smaller ones. Key objectives of why .svg support is crucial for advanced content that Magento supports with 2.3 release:

Preconditions:

User is on the following pages:

Acceptance Criteria

Additional information

media-gallery-svg

orlangur commented 6 years ago

@tkacheva do you mean that SVG support can be just returned back or there needs to be a more sophisticated fix for a stored XSS vulnerability?

luke-underwood commented 6 years ago

+1. I use SVGs everywhere I can as modern web designs should. The initial security fix should not have been simply removing upload support for SVG altogether

andy17612 commented 5 years ago

can you say how to use SVGs everywhere? thank you! @SnarkieDesign

p24-max commented 8 months ago

Magento admin media gallery is used by trusted users only. If they want to add malicious JavaScript, they can also do this in a CMS-page with pagebuilder "html" element... Please allow SVG or add an option to enable/disable it.