search

magento / community-features

Magento Features Development is an Initiative to Allows Community Memebers Join to Development of Magento Features
46 stars 18 forks source link

feature request: make _calcHeight and _isOverflowed of minicart sidebar.js optional #83

Open magento-engcom-team opened 5 years ago

magento-engcom-team commented 5 years ago

Preconditions

  1. add more than 6 items to the cart
  2. open the minicart
  3. all current Magento versions (2.2.4+, 2.3, 2.1.x)

Steps to reproduce

  1. open the minicart
  2. the

Expected result

  1. an option to disable both methods to prevent the calculated height / scroll

Actual result

  1. I can not disable these options without overwriting sidebar.js

I think it also makes sense to optionally support some maxHeight value instead of maxItems value as some items have many lines of text in the name in some shops (long product names which include product attributes) so 65 items for example could also take much height. When we make both optionally we can use CSS values however we want to.

Original Report: https://github.com/magento/magento2/issues/17433 by @DanielRuf