magento / data-migration-tool

Magento Data Migration Tool
https://devdocs.magento.com/guides/v2.3/migration/bk-migration-guide.html
Open Software License 3.0
334 stars 200 forks source link

Reducing the number of validate type calls while reading data from the map.xml file #788

Closed DmitryFurs closed 4 years ago

DmitryFurs commented 4 years ago

Description

When working with the map.xml file, the isDocumentIgnored(), isFieldIgnored() and isFieldDataTypeIgnored() methods calculate the result and store it in a local property. But in the current implementation, some methods run validateType() on each call, before checking for the calculated value. Other protected methods may call validateType() a second time during value calculation.

Contribution checklist

victor-v-rad commented 4 years ago

Hi @DmitryFurs

Thank you for your contribution to the project. MC-31139 was created to process it.

ghost commented 4 years ago

Hi @DmitryFurs, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.