magento / data-migration-tool

Magento Data Migration Tool
https://devdocs.magento.com/guides/v2.3/migration/bk-migration-guide.html
Open Software License 3.0
336 stars 200 forks source link

fix(mysql): independently set ssl_ca, ssl_cert, and ssl_key #820

Closed damienwebdev closed 4 years ago

damienwebdev commented 4 years ago

Description

This PR allows developers to indepdently set ssl_ca, ssl_cert and ssl_key.

Not all SSL connections require a key, cert and CA file. For instance, Azure Database for MySQL enables SSL connections with only a CA file. See: https://docs.microsoft.com/en-us/azure/mysql/howto-configure-ssl This commit allows developers to port M1 databases out of Azure Database for MySQL to another environment without compromising security.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

  1. Try to create a connection to an Azure Database for MySQL by setting ssl_ca in the database config.
  2. Run bin/magento migrate:settings
  3. Fail with SQLSTATE[HY000] [9002] SSL connection is required. Please specify SSL options and retry.

Contribution checklist

ghost commented 4 years ago

Hi @damienwebdev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.