magento / data-migration-tool

Magento Data Migration Tool
https://devdocs.magento.com/guides/v2.3/migration/bk-migration-guide.html
Open Software License 3.0
334 stars 200 forks source link

2.4.4 not compatible with php 8.1? #893

Open rbrown opened 2 years ago

rbrown commented 2 years ago

Sorry, I can't see anywhere mentioning whether this is compatible with 8.1, but after upgrading form 2.4.3, running bin/magento returns

bin/magento setup:upgrade
PHP Fatal error:  During inheritance of Iterator: Uncaught Exception: Deprecated Functionality: Return type of Migration\ResourceModel\AbstractCollection::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /magento2/vendor/magento/data-migration-tool/src/Migration/ResourceModel/AbstractCollection.php on line 35 in /magento2/vendor/magento/framework/App/ErrorHandler.php:61

I don't think it's a caching error, https://github.com/magento/data-migration-tool/blob/2.4-develop/src/Migration/ResourceModel/AbstractCollection.php is not specifying the return type?

m2-assistant[bot] commented 2 years ago

Hi @rbrown. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


DmitryFurs commented 2 years ago

It seems like the data-migration-tool should use attributes for places like in the magento2 repository

victor-v-rad commented 2 years ago

@rbrown the issue fixed in 2.4-develop Please install DMT from that branch or use php 7.4 as a workaround while migration

andreidragutu commented 2 years ago

Please fix ASAP for 2.4.4, we need to install this on Magento Cloud with php 8.1

tschirmer commented 2 years ago

Same issue

mrrobotisback commented 2 years ago

@victor-v-rad composer require magento/data-migration-tool:dev-2.4-develop not work.

[InvalidArgumentException] Could not find package magento/data-migration-tool in a version matching "dev-2.4-develop" and a stability matching "dev".

How can i require 2.4-develop ?

thanks in advance

andreidragutu commented 2 years ago

Hi, what is the status here? When will a fix be ready for Adobe Commerce 2.4.4?

vrielsa commented 1 year ago

Had the same issue for our client. We applied the PHP 8.1 fixes commit as a patch until it gets released. https://github.com/magento/data-migration-tool/commit/4341f38400d9eec3e502237337337928620a4f0f.patch

andreidragutu commented 1 year ago

@victor-v-rad Is this fixed in 2.4.4-p1 or 2.4.5 release? Thanks!

frozenpandaman commented 1 month ago

Is any fix available?