Closed hostep closed 6 years ago
Hi @hostep, our policy for 2.2.0 release notes is to include all the issues we've fixed since 2.1.0. So yes: You've seen many, but not all, of these notes before.
You do have a good memory!
I'll remove the duplicates -- it's been hard to catch all the duplicates because issues that have been included in an earlier 2.1.x and then are ported to 2.2 are identified in our internal JIRA database by different issue numbers.
Thanks again.
Ok, that's unfortunate, I would have expected to only see the changes between the last released 2.1.x version before 2.2.0 was released (2.1.9 in this case). That's much more easy to understand to see what actually changed when you want to upgrade from the latest 2.1.x to 2.2.0 to see what was actually changed.
I'll remove the duplicates -- it's been hard to catch all the duplicates because issues that have been included in an earlier 2.1.x and then are ported to 2.2 are identified in our internal JIRA database by different issue numbers.
This would not have occured if you didn't include the fixes from 2.1.x in here ;)
So next to the duplicate and already released fixes remarks, there is one other which you might have missed:
JavaScript translations of warning messages no longer appear in the language of the primary locale only. Previously, optimizations that we made to static content deployment inadvertently generated the content only in the language of the primary locale, and then copied that directory to the other requested locales. GitHub-7862
This is not fixed, it broke again in Magento 2.2.0 after fixing it in a related issue. See https://github.com/magento/magento2/issues/7862#issuecomment-331070332 for more details
Hi @hostep, I made another round of edits to remove the duplicates you pointed out plus a few I caught on my own and published those changes last night (Austin time). Thanks again for your careful reading; I genuinely appreciate it.
The JavaScript issue you mentioned is marked as fixed in our internal JIRA project -- let me follow up on that. Before I remove the issue from the release notes I need to be able to annotate the JIRA issue so that the history of the issue and fix (or un-fix here) is captured. The Austin office is awake now, and I'm sure I'll be able to follow up in the next few hours.
You are totally right about how our current strategy really invites unintentional replication of issues. I am planning on following up on that in the next few weeks. My focus has been on getting highlights, community contributions, and known issues into the notes, and frankly haven't thought much about redesigning the fixed-issues section. But it's on my radar now.
I will follow up on the JavaScript issue this morning and will republish the notes later today. I will close this issue then, if you don't mind.
Thanks again!
@hostep, I followed up on the JavaScript issue -- I've removed the issue description from the Fixed Issues section of the release notes, and we've re-opened the JIRA issue. I'll close this issue in 24 hours unless I hear otherwise from you. Thanks again.
Thanks @jfrontain, good work! :)
Feedback on page: /guides/v2.2/release-notes/ReleaseNotes2.2.0CE.html
This was fixed in Magento 2.1.1, so it makes no sense to have this on the Magento 2.2.0 release notes. Be aware, this is also mentioned twice in the release notes, so you have to remove it twice. (first and thirteenth bullet point under the 'Installation, upgrade, deployment')
Same problem, this was already fixed in Magento 2.1.4, shouldn't be mentioned in the 2.2.0 release notes.
This has been reported twice in the release notes (eight and fourteenth bullet point)
Same thing, they are all mentioned twice, please clean those up :)
This is not fixed, it broke again in Magento 2.2.0 after fixing it in a related issue. See https://github.com/magento/magento2/issues/7862#issuecomment-331247899 for more details
This was fixed in Magento 2.1.3, so it makes no sense to have this on the Magento 2.2.0 release notes.
These were all fixed in Magento 2.1.8, so it makes no sense to have this on the Magento 2.2.0 release notes.
These were all fixed in Magento 2.1.6, so it makes no sense to have this on the Magento 2.2.0 release notes.
These are duplicates, I think it's best to remove the last one.
These were all fixed in Magento 2.1.3, so it makes no sense to have this on the Magento 2.2.0 release notes.
Was fixed in Magento 2.1.1, so it makes no sense to have this on the Magento 2.2.0 release notes.
Was fixed in Magento 2.1.8, so it makes no sense to have this on the Magento 2.2.0 release notes.
These are only a couple ones I encountered when going through the release notes, since I somehow was involved in most of the above or because I have a good memory I guess. But I'm pretty sure there will be other mistakes in there, so please review the release notes very carefully.
Thanks! :)