magento / devdocs

[Deprecated] Magento Developer Documentation
Open Software License 3.0
674 stars 1.76k forks source link

variable-pool link leads to 404 page #2107

Closed jonashrem closed 6 years ago

jonashrem commented 6 years ago

This issue is a:

Link to https://devdocs.magento.com/guides/v2.2extension-dev-guide/variable-pool/ leads to 404 page

Steps to reproduce

  1. Open module development page https://devdocs.magento.com/guides/v2.2/extension-dev-guide/module-development.html
  2. click on "Variable Pool"

Expected result:

Seeing a page about the "Variable Pool"

Possible solutions:

In the development branch of this docs there is a page about "Variable Pool" in 2.3 ( https://github.com/magento/devdocs/blob/develop/guides/v2.3/extension-dev-guide/variable-pool/index.md ) When this is a 2.3 feature the link in 2.2 and earlier should be removed. If this feature is present in 2.2 the page should be ported to 2.2 as well

jeff-matthews commented 6 years ago

Thanks @jonashrem. There are two things going on here:

  1. The link definition is missing a forward slash, which will cause a 404.
  2. The TOC file isn't restricting this topic to the 2.3 version as it should, so it appears in all versions of the TOC even though the file only exists in 2.3.

_data/toc/php-developer-guide.yml

Incorrect

- label: Variable Pool
  url: extension-dev-guide/variable-pool/

Correct

- label: Variable Pool
  versions: ["2.3"]
  url: /extension-dev-guide/variable-pool/

@jcalcaben, please confirm that this topic only belongs in 2.3.

jcalcaben commented 6 years ago

Thanks for reporting this @jonashrem !

This topic is a 2.3-only topic. I have fixed the table of contents so it only appears in 2.3.