search

magento / ece-tools

All Submissions you make to Magento Inc. (“Magento") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here: https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html
Open Software License 3.0
117 stars 83 forks source link

MC-37292: Make 'quality-patches' a hard dependency for ece-tools and soft dependency for magento-cloud-patches #779

Closed viktym closed 4 years ago

viktym commented 4 years ago

Description

Refactor extensibility approach for magento-cloud-patches & quality-patches to eliminate circular dependency between packages:

Fixed Issues (if relevant)

MC-37292: Make 'quality-patches' a hard dependency for ece-tools and soft dependency for magento-cloud-patches

Related PR

Manual testing scenarios

TBD

Release notes

For user-facing changes, add a meaningful release note. For examples, see Magento Cloud ECE-tools release notes.

Associated documentation updates

Add link to Magento DevDocs PR or Issue, if needed.

Contribution checklist

BarnyShergold commented 4 years ago

@magento run all tests

BarnyShergold commented 4 years ago

@magento run all tests

BaDos commented 4 years ago

Please see this PR: https://github.com/magento/ece-tools/pull/780

ghost commented 4 years ago

Hi @viktym, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.