`id` in Region is unnecessary

magento / graphql-ce

[ARCHIVED] Please use magento/magento2 project

https://github.com/magento/magento2

Open Software License 3.0

131 stars 156 forks source link

`id` in Region is unnecessary #1018

Closed buskamuza closed 4 years ago

buskamuza commented 4 years ago

region_id is deprecated in all places. Thus id in Region is unnecessary. Any logic should rely on Region.code.

AC:

Region.id is deprecated

fooman commented 4 years ago

Isn't this direction opposite to what the PWA team is looking for here https://github.com/magento/graphql-ce/issues/930 ?

buskamuza commented 4 years ago

Closing this one in favor of generic approach with having ids in entities that can be cached - https://github.com/magento/devdocs/pull/5872 Not sure if region needs to be cached, but potentially it's possible. So let's keep the functionality if it's already there.