Unnecessary base currency

magento / graphql-ce

[ARCHIVED] Please use magento/magento2 project

https://github.com/magento/magento2

Open Software License 3.0

131 stars 156 forks source link

Closed buskamuza closed 4 years ago

buskamuza commented 5 years ago

Base currency is information used in admin only, and in calculations on backend. Frontend applications should not deal with base currency.

AC:

Currency.base_currency_code is deprecated
Currency.base_currency_symbol is deprecated
base_currency_symbol is added to StoreConfig so that StoreConfig data can be used for anything related to base currency.

buskamuza commented 5 years ago

There is also StoreConfig.base_currency_code