Closed osrecio closed 4 years ago
Hi @osrecio It would be great to cover this change with GraphQL test
💡New dependency on Magento\Directory
module should be approved via Magento Approval Request. It is pre-approved right now with @maghamed during the contribution day. Customer
module does not have the proper API to execute this logic.
Please take a look at Case 3 in #1032
@osrecio could you please address the failed test case found by @TomashKhamlai. Thank you.
Hi @lenaorobei, thank you for the review. ENGCOM-6255 has been created to process this Pull Request :eight_spoked_asterisk: @lenaorobei, could you please add one of the following labels to the Pull Request?
Label | Description |
---|---|
Auto-Tests: Covered |
All changes in Pull Request is covered by auto-tests |
Auto-Tests: Not Covered |
Changes in Pull Request requires coverage by auto-tests |
Auto-Tests: Not Required |
Changes in Pull Request does not require coverage by auto-tests |
Hi @osrecio, thank you for your contribution! Please, complete Contribution Survey, it will take less than a minute. Your feedback will help us to improve contribution process.
Description (*)
Adding a validation with country and postcode to set is required for the mutation createCustomerAddress
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)