magento / graphql-ce

[ARCHIVED] Please use magento/magento2 project
https://github.com/magento/magento2
Open Software License 3.0
131 stars 156 forks source link

#1029 Add Postcode as required depending of the country Mutation createCustomerAddress #1031

Closed osrecio closed 4 years ago

osrecio commented 5 years ago

Description (*)

Adding a validation with country and postcode to set is required for the mutation createCustomerAddress

Fixed Issues (if relevant)

  1. magento/graphql-ce#1029: Postcode is not listed in the array of errors

Manual testing scenarios (*)

  1. Described in: magento/graphql-ce#1029

Questions or comments

Contribution checklist (*)

okorshenko commented 5 years ago

Hi @osrecio It would be great to cover this change with GraphQL test

okorshenko commented 5 years ago

💡New dependency on Magento\Directory module should be approved via Magento Approval Request. It is pre-approved right now with @maghamed during the contribution day. Customer module does not have the proper API to execute this logic.

TomashKhamlai commented 5 years ago

Please take a look at Case 3 in #1032

lenaorobei commented 5 years ago

@osrecio could you please address the failed test case found by @TomashKhamlai. Thank you.

magento-engcom-team commented 5 years ago

Hi @lenaorobei, thank you for the review. ENGCOM-6255 has been created to process this Pull Request :eight_spoked_asterisk: @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests
ghost commented 4 years ago

Hi @osrecio, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.