Cover negative case when country_code was omitted

magento / graphql-ce

[ARCHIVED] Please use magento/magento2 project

https://github.com/magento/magento2

Open Software License 3.0

131 stars 155 forks source link

Cover negative case when country_code was omitted #1047

Closed TomashKhamlai closed 5 years ago

TomashKhamlai commented 5 years ago

Description (*)

Covers negative case when country_code was omitted.

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds are green)

TomashKhamlai commented 5 years ago

Cover #1041 #1044 Will be skipped after failure

lenaorobei commented 5 years ago

@magento run Database Compare

lenaorobei commented 5 years ago

Hi @TomashKhamlai. The schema looks following:

input CartAddressInput {
 firstname: String!
 lastname: String!
 company: String
 street: [String!]!
 city: String!
 region: String
 postcode: String
 country_code: String!
 telephone: String!
 save_in_address_book: Boolean
}

country_code is required input parameter and the case that validation does not properly happening shows that it is a framework bug. Such validation should not happen in resolvers and such test cases are redundant.

Closing this PR since the framework bug is assigned to the internal team.

ghost commented 5 years ago

Hi @TomashKhamlai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.