magento/graphql-ce#: Add missed annotation blocks to Magento\GraphQl\Customer\CreateCustomerTest

magento / graphql-ce

[ARCHIVED] Please use magento/magento2 project

https://github.com/magento/magento2

Open Software License 3.0

131 stars 156 forks source link

magento/graphql-ce#: Add missed annotation blocks to Magento\GraphQl\Customer\CreateCustomerTest #1051

Closed atwixfirster closed 4 years ago

atwixfirster commented 4 years ago

Description (*)

PR adds missed annotation blocks to Magento\GraphQl\Customer\CreateCustomerTest + misspelling fix.

Fixed Issues (if relevant)

magento/magento2#: Issue title

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds are green)

Thank you!

atwixfirster commented 4 years ago

Hi @atwixfirster. The use of @inheritdoc is in general discouraged. Please see the reference - https://devdocs.magento.com/guides/v2.3/coding-standards/docblock-standard-general.html#inheritdoc. For tiny cleanup fixes please combine into 1 PR. It should contain fixes for at leas all Customer tests. Thank you.

@lenaorobei , I have updated the descriptions. Could you please verify? Thanks

lenaorobei commented 4 years ago

As per documentation: A short description in case it adds meaningful information beyond the method name. I believe that methods like setUp already have meaningful description, so additional info not needed.

lenaorobei commented 4 years ago

You can check for other typos in the dev/tests/api-functional/testsuite/Magento/GraphQl/Customer folder. Example: testChangeSubscriptionStatuIfUserIsNotAuthorizedTest.

atwixfirster commented 4 years ago

You can check for other typos in the dev/tests/api-functional/testsuite/Magento/GraphQl/Customer folder.

done

Thank you, @lenaorobei

lenaorobei commented 4 years ago

@magento run Database Compare

magento-engcom-team commented 4 years ago

Hi @lenaorobei, thank you for the review. ENGCOM-6245 has been created to process this Pull Request

ghost commented 4 years ago

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.