Refactor Magento\GraphQl\Quote\Customer\GetCustomerCartTest - Githubissues

magento / graphql-ce

[ARCHIVED] Please use magento/magento2 project

https://github.com/magento/magento2

Open Software License 3.0

131 stars 156 forks source link

Refactor Magento\GraphQl\Quote\Customer\GetCustomerCartTest #1056

Closed TomashKhamlai closed 4 years ago

TomashKhamlai commented 4 years ago

Description (*)

Refactoring:

removed function for getting customer_token. (duplication)
removed assertion from private function revokeCustomerToken that is nod considered as a test and already covered with tests

Fixed Issues (if relevant)

magento/graphql-ce#1055: Tests from GetCustomerCartTest failed locally. Tests have assertions outside of testFunctions

Manual testing scenarios (*)

Run tests for Quote module or just
- testGetNewCustomerCart
- testGetCustomerCartAfterTokenRevoked
- testRequestCustomerCartTwice

Questions or comments

Contribution checklist (*)

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds are green)

ghost commented 4 years ago

Hi @TomashKhamlai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.