#1054: Add e-mail address validation to customer data validation for GraphQL

vasylmalanka commented 5 years ago

The goal is to make customer e-mail address validation in accordance to the validation in Admin panel.

Currently, there are 2 validation on customer create/edit page in Admin: 1) frontend validation (see 'validate-email' in app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js), 2) backend validation (see '_validateInputRule' in www/app/code/Magento/Eav/Model/Attribute/Data/AbstractData.php).

In order to make validation in GraphQL working the same, the check using regular expression from JS validation was used as a first step and original Zend validation as a second.

magento/graphql-ce#1054: Emails validation works differently

Contribution checklist (*)

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds are green)

m2-community-project[bot] commented 5 years ago

@TomashKhamlai unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

lenaorobei commented 4 years ago

@magento run Functional Tests

ghost commented 4 years ago

Hi @vasylmalanka, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento / graphql-ce

#1054: Add e-mail address validation to customer data validation for GraphQL #1073

Contribution checklist (*)