magento / graphql-ce

[ARCHIVED] Please use magento/magento2 project
https://github.com/magento/magento2
Open Software License 3.0
131 stars 156 forks source link

magento/graphql-ce#977: [Test coverage] Cover exceptions in AssignShippingAddressToCart, AssignBillingAddressToCart #996

Closed atwixfirster closed 4 years ago

atwixfirster commented 4 years ago

Description (*)

Fixed Issues (if relevant)

  1. magento/graphql-ce#977: [Test coverage] Cover exceptions in AssignShippingAddressToCart, AssignBillingAddressToCart

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

Thank you!

atwixfirster commented 4 years ago

Please set address not from the address book (send address in mutation body, not customer_address_id) so we will test invalid input. customer_address_set_invalid_country_id.php fisture should be removed.

Good suggestion!

implemented

Thank you, @lenaorobei

magento-engcom-team commented 4 years ago

Hi @lenaorobei, thank you for the review. ENGCOM-6061 has been created to process this Pull Request :eight_spoked_asterisk: @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests
lenaorobei commented 4 years ago

@atwixfirster please pull latest code from 2.3-develop and resolve conflicts.

atwixfirster commented 4 years ago

@atwixfirster please pull latest code from 2.3-develop and resolve conflicts.

done, ma'am :)

ghost commented 4 years ago

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.