Quantity per Source Column breaks Saved Views in Product Grid

perfpcs commented 3 years ago

Preconditions (*)

In the latest Magento 2.4.1 ythere is a bug where if you enable in the grid the column "Quantity per Source" and then enable this column and save it in any views, those views are never recoverable. Clicking on your saved view will bring a random assortment of columns and not anything like how you saved them.

Steps to reproduce (*)

Our Developers did the following to determine the cause of the issue. We made a copy of the clean Magento database (from new.performance-pcs.com) and connected it to dev.performance-pcs.com, and afterward, we saw that the problem disappeared. But this does not mean that the problem is not related to some third-party module.

The module could be turned off, but before that, it could have affected the database and thus, cause the problem.

We then compared the attributes that are displayed in the product grid on the clean Magento database and on the dev site database.

After comparing discrepancies and many tests, we found that the problem occurs because of the column in the product grid "Quantity per Source". Stores -> Inventory -> Sources For the test, we excluded the Amazon source on https://dev.performance-pcs.com/ https://monosnap.com/file/FswVAdiZiewDl4uPmsRcf0JXRBJB97

Then, the preservation started working on the grid product.

Afterward, we created an Inventory Source at https://new.performance-pcs.com/ https://monosnap.com/file/A61Rc2ih0m4TU6WWnUcbKt1nuyuJSi

After which the preservation of the product of the grid stopped working.

You can compare the grid between https://new.performance-pcs.com/ and https://dev.performance-pcs.com/

This is Magento bug and we tried it on the clean Magento installation without third-party modules.

Here is the file that causes the issue: vendor/magento/module-inventory-catalog-admin-ui/Ui/DataProvider/Product/Listing/Modifier/QuantityPerSource.php

Expected result (*)

I expect the grid to always return to my saved view after leaving the product page and returning to the grid. And switching views should return previous saved views. example:

Actual result (*)

This is how grid looks when you leave the grid page and return or select it from choice of views:

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

[ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
[ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
[X ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
[ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
[ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

m2-assistant[bot] commented 3 years ago

Hi @perfpcs. Thank you for your report. To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

m2-assistant[bot] commented 3 years ago

Hi @engcom-Alfa. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

[ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
[ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
[ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
[ ] 4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
[ ] 5. Add label Issue: Confirmed once verification is complete.
[ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Alfa commented 3 years ago

Hi @perfpcs.

Looks like this issue related to MSI functionality. @sdzhepa Could you move this ticket to the Inventory repository? Thanks!

perfpcs commented 3 years ago

@engcom-Alfa thank you...hope its an easy fix :)

perfpcs commented 3 years ago

@sdzhepa Could you move this ticket to the Inventory repository? If that's where it needs to go to get fixed?

m2-assistant[bot] commented 3 years ago

Hi @perfpcs. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

perfpcs commented 3 years ago

Hi all, I am not sure what else I can provide? It is very clear what the problem is and is confirmed by our developers. It is a matter of the community who can fix the issue. thank

dave12dev commented 10 months ago

@perfpcs We just started using MSI and quantity per source on our grid (Magento 2.4.5-p1) and are experiencing the exact same issue. Did you manage to find a workaround to this or is it still being worked on?

magento / inventory